Skip to content

USB Device improvements and stability fixes #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 12, 2015
Merged

USB Device improvements and stability fixes #27

merged 13 commits into from
Oct 12, 2015

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Aug 19, 2015

This pull request contains a clean up of the USB Device stack and fixes for a bunch of bugs:

  • Source code has been rationalized by removing duplicate code scattered among samd21_device.c, samd21_device.h and USB_device.h.
  • Fixed a bug in blocking-send buffering for USBDevice
  • Fixed a bug in HID device descriptor handling
  • Stability improvement in back-to-back SerialUSB communication

/cc @facchinm
/cc @aethaniel

@cmaglie cmaglie self-assigned this Aug 19, 2015
@facchinm facchinm mentioned this pull request Sep 7, 2015
Merged
@facchinm
Copy link
Member

facchinm commented Sep 7, 2015

I've being testing it for more than a week (and another month before this PR) and it works well with PluggableUSB patches applied on top (#35)
👍 for merging asap 😄

@cmaglie
Disabled SRAM shortcut when in USBCore::send
ac16594 
The shortcut has some issues:

- sometimes it fails when sending an odd number of bytes (may be
  due to memory alignment?)
- the data pointer should point to "stable" data (and this is not
  guaranteed by caller, it may be some sort of temporary buffer)
- the SRAM is not guaranteed to start at 0x20000000

All the above problems must be properly fixed before reenabling
this part
@cmaglie
Fixed bug in USBCore::send... (yikes!)
81cbda3
@cmaglie
Copy link
Member Author

cmaglie commented Sep 10, 2015

Pushed (yet) another fix.

@ArduinoBot
Copy link

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/samd/package_samd-b34_index.json

ℹ️ To test this build:

  1. Open the Preferences of the Arduino IDE.
  2. Add the Build URL above in the Additional Boards Manager URLs field, and click OK.
  3. Open the Boards Manager (menu Tools->Board->Board Manager...)
  4. Install Arduino SAMD core - Pull Request USB Device improvements and stability fixes #27
  5. Select one of the boards under SAMD Pull Request USB Device improvements and stability fixes #27 in Tools->Board menu
  6. Compile/Upload as usual

@facchinm facchinm mentioned this pull request Sep 22, 2015
Merged
@cmaglie cmaglie merged commit 81cbda3 into arduino:master Oct 12, 2015
@cmaglie cmaglie deleted the usb-fixes branch October 12, 2015 15:41
@cmaglie cmaglie added this to the Release 1.6.2 milestone Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cmaglie cmaglie

Labels
bug Component: USB Device improvement
Projects
None yet
Milestone
Release 1.6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@cmaglie @facchinm @ArduinoBot @jcbuda